Skip to content

add summary for invalid org issue - #135

Merged
pooleycodes merged 1 commit into
mainfrom
bug/no-org-issue-summary
Jul 28, 2026
Merged

add summary for invalid org issue#135
pooleycodes merged 1 commit into
mainfrom
bug/no-org-issue-summary

Conversation

@pooleycodes

@pooleycodes pooleycodes commented Jul 28, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

There was no issue summary for invalid organisation errors, so the task would appear but with no summary, blocking the issue from showing through.

Related Tickets & Documents

  • Ticket Link
  • Related Issue #
  • Closes #

QA Instructions, Screenshots, Recordings

Please replace this line with instructions on how to test your changes, a note
on the devices and browsers this has been tested on, as well as any relevant
images for UI changes.

Added/updated tests?

We encourage you to keep the code coverage percentage at 80% and above. Please refer to the Digital Land Testing Guidance for more information.

  • Yes
  • No, and this is why: please replace this line with details on why tests
    have not been included
  • I need help with writing tests

[optional] Are there any post deployment tasks we need to perform?

[optional] Are there any dependencies on other PRs or Work?

@coderabbitai

coderabbitai Bot commented Jul 28, 2026 •
edited
Loading

Copy link
Copy Markdown

Review Change Stack

Walkthrough

The validation-to-message mapping now handles invalid organisation values with a description and singular/plural summary messages.

Changes

Organisation validation

Layer / File(s) Summary
Add organisation validation messages
request-processor/src/application/configs/mapping.yaml		 Adds mappings for the invalid organisation issue type, including description and singular/plural summaries.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the change: adding a summary for invalid organisation issues.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch bug/no-org-issue-summary

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

gibahjoe
gibahjoe approved these changes Jul 28, 2026
View reviewed changes

@gibahjoe gibahjoe left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pooleycodes
pooleycodes merged commit 4657e33 into main Jul 28, 2026
3 checks passed
@pooleycodes
pooleycodes deleted the bug/no-org-issue-summary branch July 28, 2026 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gibahjoe gibahjoe gibahjoe approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pooleycodes @gibahjoe